docs(admin): record installed-VM acceptance evidence for the approval and settings fixes
Some checks are pending
ci / test (push) Waiting to run

This commit is contained in:
Phoebus 2026-09-24 22:24:13 -07:00
parent b579633ab1
commit 249166a0b0
2 changed files with 33 additions and 27 deletions

View file

@ -21,9 +21,11 @@ Found while running the acceptance on a fresh disposable installed system:
longer written to the system transaction history; only `requires_root()` longer written to the system transaction history; only `requires_root()`
actions are recorded. Covered by a CLI regression test that makes the system actions are recorded. Covered by a CLI regression test that makes the system
transaction directory read-only. transaction directory read-only.
- **Installed-VM evidence (disposable qcow2, detached boot):** LUKS unlock and - **Installed-VM evidence (disposable qcow2):** a clean install with the fixed
login; systemd PID1 `running`; `sys 0.1.0`; `sys history --legacy` exit 0; installer completes (`===INSTALL-RC=0===`, `installation finished`,
and `installer/tests/vm/sys-acceptance.sh` with the fixed `sys` reports `NO_SECRET_LEAK`). Detached boot: LUKS unlock and login; systemd PID1
`running`; `sys 0.1.0`; `sys history --legacy` exit 0; and
`installer/tests/vm/sys-acceptance.sh` with the fixed `sys` reports
`SUMMARY PASS=24 FAIL=0`, including `personal-preference PASS saved to user `SUMMARY PASS=24 FAIL=0`, including `personal-preference PASS saved to user
config` and `nonroot-systemwide` correctly refused. The privileged `--broker` config` and `nonroot-systemwide` correctly refused. The privileged `--broker`
plan path and replay rejection are unit-tested at the privileged entry point plan path and replay rejection are unit-tested at the privileged entry point

View file

@ -64,30 +64,32 @@ commit it. It should be short and current; use `git log` for detail.
- `cargo clippy --workspace --all-targets` exits 0 (only the pre-existing - `cargo clippy --workspace --all-targets` exits 0 (only the pre-existing
`result_large_err`, one arg-count and one `DiskPhase` lints remain). `result_large_err`, one arg-count and one `DiskPhase` lints remain).
- `cargo build --release -p phoebus-installer` clean. - `cargo build --release -p phoebus-installer` clean.
- **Disposable installed VM (qcow2, detached boot):** LUKS unlock + login; - **Disposable installed VM, clean install (`verify-disk2.qcow2`, qcow2,
PID 1 `systemd`, `systemd is-system-running = running`; `sys 0.1.0`; detached boot):** the fixed installer completes with `===INSTALL-RC=0===`,
`sys history --legacy` exit 0; `installer/tests/vm/sys-acceptance.sh` with `installation finished`, `stage complete: finalize`, and `NO_SECRET_LEAK`.
the fixed `sys` reports `SUMMARY PASS=24 FAIL=0` (includes Detached boot: LUKS unlock + login; PID 1 `systemd`,
`personal-preference PASS saved to user config` and `nonroot-systemwide` `systemd is-system-running = running`; `sys 0.1.0`; `sys history --legacy`
correctly refused). exit 0; `installer/tests/vm/sys-acceptance.sh` with the fixed `sys` reports
- Two defects found and fixed by the VM run: (a) the installer `finalize` `SUMMARY PASS=24 FAIL=0`, including `personal-preference PASS saved to user
`sys` probe ran the AI-first `sys history` and aborted a `--no-ai` install; config` and `nonroot-systemwide` correctly refused.
it now runs `sys history --legacy` (`phoebus-executor::sys_runtime`, - Two defects found and fixed by the VM runs: (a) the installer `finalize`
unit-tested); (b) a personal preference wrote the preference but then failed `sys` probe ran the AI-first `sys history` and aborted a `--no-ai` install
recording it in the root-owned `/var/lib/phoebus/transactions.toml`; personal with `INSTALL-RC=1`; it now runs `sys history --legacy`
preferences are now excluded from the system transaction history. (`phoebus-executor::sys_runtime`, unit-tested) and the clean install
- **Not yet verified this session (BLOCKED):** completed; (b) a personal preference wrote the preference but then failed
recording it in the root-owned `/var/lib/phoebus/transactions.toml`;
personal preferences are now excluded from the system transaction history
(CLI regression with a read-only transaction directory).
- **Not yet verified (BLOCKED):**
- The privileged `sys --broker --execute-plan` path and replay rejection were - The privileged `sys --broker --execute-plan` path and replay rejection were
**not** exercised end-to-end in the VM: the serial console has no root **not** exercised end-to-end in the VM: the serial console has no root
access and no Polkit agent (`sudo -n` denied), so `pkexec` elevation cannot access and no Polkit agent (`sudo -n` denied), so `pkexec` elevation cannot
complete. These paths remain unit-tested at the `execute_plan_privileged` complete. These paths remain unit-tested at the `execute_plan_privileged`
entry point (replacement, recomputed digest, step_effects tampering, replay, entry point (replacement, recomputed digest, `step_effects` tampering,
concurrency, interruption). A graphical/seat-providing VM or a replay, concurrency, interruption). A graphical/seat-providing VM or a
passwordless-sudo test image is required for the end-to-end run. passwordless-sudo test image is required for the end-to-end run.
- The existing `test-disk.qcow2` still cannot be unlocked (unknown passphrase); - The pre-existing `test-disk.qcow2` still cannot be unlocked (unknown
do not guess or brute-force. A clean re-install with the fixed installer is passphrase); do not guess or brute-force.
running at the time of writing (`verify-disk2.qcow2`); its result is recorded
in the follow-up if it completes.
- No AI provider credential is present; do not invent one. - No AI provider credential is present; do not invent one.
- A real privileged `chown` (running as root) could not be exercised on this - A real privileged `chown` (running as root) could not be exercised on this
unprivileged host; verified through the injectable fixer seam and the unprivileged host; verified through the injectable fixer seam and the
@ -97,11 +99,13 @@ commit it. It should be short and current; use `git log` for detail.
## Next actions (in order) ## Next actions (in order)
1. **Unlock or rebuild the installed VM (blocker).** The installed disk reaches 1. **Privileged `--broker` acceptance in a seat-providing VM.** The read-only
the LUKS prompt but its passphrase is unknown; the committed harness default acceptance and personal preferences are verified on the clean install
is rejected. Either supply the real passphrase or perform a fresh disposable (`verify-disk2.qcow2`, 24/24). The remaining unverified path is the actual
install (~2 h) to obtain an installed system, then run the full 12-step `pkexec` elevation into `sys --broker --execute-plan` (replacement during
acceptance list below. authentication, replay after deleting user plan state, cancellation, a real
privileged `chown`). It needs a graphical Polkit agent or a
passwordless-sudo disposable test image; the serial console cannot elevate.
2. **Installed `sys` acceptance** on the booted disk: 2. **Installed `sys` acceptance** on the booted disk:
```sh ```sh
# serve the static sys first: # serve the static sys first: