From 249166a0b0d6c9fc9e3e96a319a2b894ba5bcd15 Mon Sep 17 00:00:00 2001 From: Phoebus Date: Thu, 24 Sep 2026 22:24:13 -0700 Subject: [PATCH] docs(admin): record installed-VM acceptance evidence for the approval and settings fixes --- docs/CHANGELOG.md | 8 +++++--- docs/HANDOFF.md | 52 +++++++++++++++++++++++++---------------------- 2 files changed, 33 insertions(+), 27 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 7db57a9..71bc527 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -21,9 +21,11 @@ Found while running the acceptance on a fresh disposable installed system: longer written to the system transaction history; only `requires_root()` actions are recorded. Covered by a CLI regression test that makes the system transaction directory read-only. -- **Installed-VM evidence (disposable qcow2, detached boot):** LUKS unlock and - login; systemd PID1 `running`; `sys 0.1.0`; `sys history --legacy` exit 0; - and `installer/tests/vm/sys-acceptance.sh` with the fixed `sys` reports +- **Installed-VM evidence (disposable qcow2):** a clean install with the fixed + installer completes (`===INSTALL-RC=0===`, `installation finished`, + `NO_SECRET_LEAK`). Detached boot: LUKS unlock and login; systemd PID1 + `running`; `sys 0.1.0`; `sys history --legacy` exit 0; and + `installer/tests/vm/sys-acceptance.sh` with the fixed `sys` reports `SUMMARY PASS=24 FAIL=0`, including `personal-preference PASS saved to user config` and `nonroot-systemwide` correctly refused. The privileged `--broker` plan path and replay rejection are unit-tested at the privileged entry point diff --git a/docs/HANDOFF.md b/docs/HANDOFF.md index e12d142..635f359 100644 --- a/docs/HANDOFF.md +++ b/docs/HANDOFF.md @@ -64,30 +64,32 @@ commit it. It should be short and current; use `git log` for detail. - `cargo clippy --workspace --all-targets` exits 0 (only the pre-existing `result_large_err`, one arg-count and one `DiskPhase` lints remain). - `cargo build --release -p phoebus-installer` clean. - - **Disposable installed VM (qcow2, detached boot):** LUKS unlock + login; - PID 1 `systemd`, `systemd is-system-running = running`; `sys 0.1.0`; - `sys history --legacy` exit 0; `installer/tests/vm/sys-acceptance.sh` with - the fixed `sys` reports `SUMMARY PASS=24 FAIL=0` (includes - `personal-preference PASS saved to user config` and `nonroot-systemwide` - correctly refused). - - Two defects found and fixed by the VM run: (a) the installer `finalize` - `sys` probe ran the AI-first `sys history` and aborted a `--no-ai` install; - it now runs `sys history --legacy` (`phoebus-executor::sys_runtime`, - unit-tested); (b) a personal preference wrote the preference but then failed - recording it in the root-owned `/var/lib/phoebus/transactions.toml`; personal - preferences are now excluded from the system transaction history. -- **Not yet verified this session (BLOCKED):** + - **Disposable installed VM, clean install (`verify-disk2.qcow2`, qcow2, + detached boot):** the fixed installer completes with `===INSTALL-RC=0===`, + `installation finished`, `stage complete: finalize`, and `NO_SECRET_LEAK`. + Detached boot: LUKS unlock + login; PID 1 `systemd`, + `systemd is-system-running = running`; `sys 0.1.0`; `sys history --legacy` + exit 0; `installer/tests/vm/sys-acceptance.sh` with the fixed `sys` reports + `SUMMARY PASS=24 FAIL=0`, including `personal-preference PASS saved to user + config` and `nonroot-systemwide` correctly refused. + - Two defects found and fixed by the VM runs: (a) the installer `finalize` + `sys` probe ran the AI-first `sys history` and aborted a `--no-ai` install + with `INSTALL-RC=1`; it now runs `sys history --legacy` + (`phoebus-executor::sys_runtime`, unit-tested) and the clean install + completed; (b) a personal preference wrote the preference but then failed + recording it in the root-owned `/var/lib/phoebus/transactions.toml`; + personal preferences are now excluded from the system transaction history + (CLI regression with a read-only transaction directory). +- **Not yet verified (BLOCKED):** - The privileged `sys --broker --execute-plan` path and replay rejection were **not** exercised end-to-end in the VM: the serial console has no root access and no Polkit agent (`sudo -n` denied), so `pkexec` elevation cannot complete. These paths remain unit-tested at the `execute_plan_privileged` - entry point (replacement, recomputed digest, step_effects tampering, replay, - concurrency, interruption). A graphical/seat-providing VM or a + entry point (replacement, recomputed digest, `step_effects` tampering, + replay, concurrency, interruption). A graphical/seat-providing VM or a passwordless-sudo test image is required for the end-to-end run. - - The existing `test-disk.qcow2` still cannot be unlocked (unknown passphrase); - do not guess or brute-force. A clean re-install with the fixed installer is - running at the time of writing (`verify-disk2.qcow2`); its result is recorded - in the follow-up if it completes. + - The pre-existing `test-disk.qcow2` still cannot be unlocked (unknown + passphrase); do not guess or brute-force. - No AI provider credential is present; do not invent one. - A real privileged `chown` (running as root) could not be exercised on this unprivileged host; verified through the injectable fixer seam and the @@ -97,11 +99,13 @@ commit it. It should be short and current; use `git log` for detail. ## Next actions (in order) -1. **Unlock or rebuild the installed VM (blocker).** The installed disk reaches - the LUKS prompt but its passphrase is unknown; the committed harness default - is rejected. Either supply the real passphrase or perform a fresh disposable - install (~2 h) to obtain an installed system, then run the full 12-step - acceptance list below. +1. **Privileged `--broker` acceptance in a seat-providing VM.** The read-only + acceptance and personal preferences are verified on the clean install + (`verify-disk2.qcow2`, 24/24). The remaining unverified path is the actual + `pkexec` elevation into `sys --broker --execute-plan` (replacement during + authentication, replay after deleting user plan state, cancellation, a real + privileged `chown`). It needs a graphical Polkit agent or a + passwordless-sudo disposable test image; the serial console cannot elevate. 2. **Installed `sys` acceptance** on the booted disk: ```sh # serve the static sys first: