fix(assistant): keep disabled Send label readable
Some checks are pending
ci / test (push) Waiting to run

This commit is contained in:
Phoebus 2026-10-03 15:16:52 -07:00
parent 67fddf1299
commit fcdb70bb5e
4 changed files with 20 additions and 5 deletions

View file

@ -5,6 +5,10 @@ this file is the curated, human-readable summary.
## Unreleased — Fast defaults with user-controlled source builds ## Unreleased — Fast defaults with user-controlled source builds
- **Readable disabled Assistant buttons (2026-10-03).** Disabled primary
controls, including Send beside Clear History, now keep a visible label and
outline. The Send control still becomes active only after text is entered.
- **Reviewed external overlay registration (2026-10-03).** `sys overlay - **Reviewed external overlay registration (2026-10-03).** `sys overlay
review <category/package>` resolves GPO leads through Gentoo's overlay review <category/package>` resolves GPO leads through Gentoo's overlay
registry and inspects each live Git repository, exact ebuild hash, amd64 registry and inspects each live Git repository, exact ebuild hash, amd64

View file

@ -3,6 +3,12 @@
Rolling note between work sessions. **Update this file before you finish**, then Rolling note between work sessions. **Update this file before you finish**, then
commit it. It should be short and current; use `git log` for detail. commit it. It should be short and current; use `git log` for detail.
- **Assistant Send visibility (2026-10-03):** The button left of Clear History
is Send. Its disabled primary style used dark text on a dark fill, making the
label almost invisible with an empty prompt. The shared QML button now uses
a visible disabled label and outline; the running disposable VM displayed it
correctly after copying the component into the user-local Assistant config.
- **External overlay registration (2026-10-03):** The next user request asked - **External overlay registration (2026-10-03):** The next user request asked
`sys` to discover compatible third-party repositories, offer a choice, then `sys` to discover compatible third-party repositories, offer a choice, then
add and keep the accepted repository synced. A deterministic review now add and keep the accepted repository synced. A deterministic review now

View file

@ -48,6 +48,11 @@ disposable VM; `serial-driver.py recovery` now automates the same check.
## Matrix ## Matrix
Assistant Send button (2026-10-03): the shared button component now renders
disabled controls with a visible label and outline. The running disposable VM
showed Send beside Clear History while the prompt was empty; the control
remained disabled. This is a user-local QML preview, not a rebuilt ISO.
External overlay registration (2026-10-03): `sys overlay review` now performs External overlay registration (2026-10-03): `sys overlay review` now performs
bounded GPO and Gentoo registry lookups, clones candidate Git repositories into bounded GPO and Gentoo registry lookups, clones candidate Git repositories into
temporary review directories, and reports exact revisions, ebuild SHA-256, temporary review directories, and reports exact revisions, ebuild SHA-256,

View file

@ -24,10 +24,9 @@ Rectangle {
implicitHeight: compact ? Theme.controlHeightCompact : Theme.controlHeightLarge implicitHeight: compact ? Theme.controlHeightCompact : Theme.controlHeightLarge
implicitWidth: Math.max(compact ? 80 : 120, labelText.implicitWidth + (compact ? 28 : 48)) implicitWidth: Math.max(compact ? 80 : 120, labelText.implicitWidth + (compact ? 28 : 48))
radius: Theme.radiusSmall radius: Theme.radiusSmall
color: actionEnabled ? baseBg : Theme.surface color: actionEnabled ? baseBg : Theme.card
border.width: (primary || danger) ? 0 : 1 border.width: (!actionEnabled || (!primary && !danger)) ? 1 : 0
border.color: activeFocus ? Theme.focusRing : Theme.border border.color: activeFocus ? Theme.focusRing : Theme.border
opacity: actionEnabled ? 1 : 0.55
activeFocusOnTab: true activeFocusOnTab: true
Accessible.role: Accessible.Button Accessible.role: Accessible.Button
Accessible.name: label Accessible.name: label
@ -66,7 +65,8 @@ Rectangle {
id: labelText id: labelText
anchors.centerIn: parent anchors.centerIn: parent
text: btn.label text: btn.label
color: (btn.primary || btn.danger) ? Theme.charcoal : Theme.warmWhite color: !btn.actionEnabled ? (Theme.isLight ? Theme.lightMuted : Theme.muted)
: (btn.primary || btn.danger) ? Theme.charcoal : Theme.warmWhite
font.family: Theme.family font.family: Theme.family
font.pixelSize: btn.compact ? Theme.fontSmall : Theme.fontBody font.pixelSize: btn.compact ? Theme.fontSmall : Theme.fontBody
font.weight: btn.primary ? Font.DemiBold : Font.Normal font.weight: btn.primary ? Font.DemiBold : Font.Normal
@ -76,7 +76,7 @@ Rectangle {
id: mouse id: mouse
anchors.fill: parent anchors.fill: parent
hoverEnabled: true hoverEnabled: true
cursorShape: Qt.PointingHandCursor cursorShape: btn.actionEnabled ? Qt.PointingHandCursor : Qt.ArrowCursor
enabled: btn.actionEnabled enabled: btn.actionEnabled
onClicked: btn.clicked() onClicked: btn.clicked()
} }