docs: record quality-pass evidence (boxed ExecError, splits, VM acceptance)
Some checks are pending
ci / test (push) Waiting to run
Some checks are pending
ci / test (push) Waiting to run
Changelog entry for the 2026-09-26 refactor; STATUS corrected to the current 38-case sys matrix with the new static-binary evidence; VM boot verification gains the sys-acceptance-refactor run; handoff updated. Verified with cargo test --workspace (692/692) and the disposable-VM matrix (guest PASS=38 FAIL=0, driver PASS=41 FAIL=0).
This commit is contained in:
parent
2dd48d1fe8
commit
15b69f524d
4 changed files with 87 additions and 3 deletions
|
|
@ -3,6 +3,42 @@
|
|||
All notable changes are recorded here. The authoritative history is `git log`;
|
||||
this file is the curated, human-readable summary.
|
||||
|
||||
## 2026-09-26 — Code quality pass: boxed ExecError, warning-free Clippy, service/gui_bridge splits
|
||||
|
||||
Structural work only; no behavior, wire-format, or serialized-plan change.
|
||||
|
||||
- `ExecError::Command` now carries a boxed `CommandFailure` payload, so
|
||||
`ExecError` shrinks from 128 to 96 bytes and `Result<T, ExecError>` passes
|
||||
Clippy's `result_large_err` gate (all 57 warnings gone). The display text,
|
||||
the redacted stdout/stderr capture, and the stderr tail used for update
|
||||
failures are preserved; the constructor and every match site were updated,
|
||||
with regression tests for the error text, the captured output, and a 96-byte
|
||||
size bound.
|
||||
- The remaining Clippy warnings are fixed without blanket allows: a type alias
|
||||
for the Snap-entry tuple (`actions.rs`), a `CommandRecord` params struct for
|
||||
`Logger::command` (`log.rs`), and `DiskPhase` variant renames
|
||||
(`gui_bridge.rs`). `cargo clippy --workspace --all-targets -- -D warnings`
|
||||
is clean.
|
||||
- `service.rs` (4218 lines) is split into `service/mod.rs` (types, render,
|
||||
shared helpers, explicit re-exports), `plan.rs`, `validation.rs`,
|
||||
`execution.rs`, and `tests.rs`. Every `phoebus_installer::service::*` path,
|
||||
the serialized plan format, approval digests, replay protection, and the
|
||||
privileged validation boundary are unchanged.
|
||||
- `gui_bridge.rs` (2763 lines) is split into `gui_bridge/mod.rs`,
|
||||
`protocol.rs` (protocol version 1, wire types, JSON observer, disk phase,
|
||||
newline-delimited JSON writer), `bridge.rs` (the single `Bridge` owning the
|
||||
installer, dispatch, installation support, secret handling), and `tests.rs`.
|
||||
No UI or wire-format change.
|
||||
- `cargo test --workspace` passes 692/692 before and after each split
|
||||
(including the 4 new `ExecError` regression tests). Release and static-pie
|
||||
builds pass.
|
||||
- The disposable VM re-ran the current `sys` acceptance matrix against the new
|
||||
static `sys` (`70f0a72b…`, fetched to `/tmp/sys` on an overlay of the
|
||||
pristine installed image): guest `PASS=38 FAIL=0` (the full 38-case matrix,
|
||||
run as the non-root user with no mutations), driver `PASS=41 FAIL=0`
|
||||
(`serial-boot-20260926T014746Z-3089a820`). Recovery boot, strict Snap
|
||||
confinement, and a revision-changing Snap update remain unverified.
|
||||
|
||||
## 2026-09-25 — Make first-use Snap setup reviewable and fix Portage target selection
|
||||
|
||||
- The normal Snap install now explains the separate, reviewed Portage install of
|
||||
|
|
|
|||
|
|
@ -3,6 +3,26 @@
|
|||
Rolling note between work sessions. **Update this file before you finish**, then
|
||||
commit it. It should be short and current; use `git log` for detail.
|
||||
|
||||
- **Quality pass (2026-09-26):** boxed `ExecError::Command` details
|
||||
(`CommandFailure`, 128 → 96 bytes, measured with a path-dependent probe crate;
|
||||
constructor + all match sites updated, error text/redaction/stderr-tail
|
||||
preserved, 4 regression tests), cleared `cargo clippy --workspace --all-targets
|
||||
-- -D warnings` with no blanket allows (type alias, `CommandRecord` params
|
||||
struct, `DiskPhase` renames), and split `service.rs` (4218 lines →
|
||||
`service/mod,plan,validation,execution,tests`) and `gui_bridge.rs`
|
||||
(2763 lines → `gui_bridge/mod,protocol,bridge,tests`) as structural refactors
|
||||
with explicit re-exports and `pub(super)` seams — no `service.rs` left
|
||||
alongside `service/mod.rs`. `make test` green (692/692, unchanged across the
|
||||
splits). Release + static-pie builds pass. The disposable VM re-ran the
|
||||
current 38-case `sys` acceptance matrix against the new static `sys`
|
||||
(`70f0a72b…`): guest `PASS=38 FAIL=0`, driver `PASS=41 FAIL=0`
|
||||
(`serial-boot-20260926T014746Z-3089a820`, overlay
|
||||
`sys-acceptance-refactor.qcow2`). Commits `e69bfb9`, `1bf31c5`, `2dd48d1`.
|
||||
- **Interface contract (unchanged):** ordinary requests use AI; only explicit
|
||||
`--legacy` selects deterministic handling; source flags constrain the AI and
|
||||
never bypass it; a missing model stops the workflow and offers the exact
|
||||
`--legacy` command without executing it.
|
||||
|
||||
- **Snap first-use follow-up (2026-09-25):** the previous "no snapd" note was a
|
||||
real integration gap. The normal `sys install … --legacy --snap` resolver needs
|
||||
snapd to confirm a Store candidate before approval, while a raw typed
|
||||
|
|
|
|||
|
|
@ -216,12 +216,16 @@ still not VM-verified.
|
|||
- **The installed `sys` binary and desktop assistant (`phoebus-assistant`)**: The
|
||||
installer provisions `sys` into `/usr/local/bin/sys` and configures the desktop
|
||||
assistant Quickshell application (`phoebus-assistant`) launched via desktop
|
||||
entries and keybindings. On the installed system, all 34 acceptance test cases
|
||||
in `installer/tests/vm/sys-acceptance.sh` pass cleanly (`PASS=34 FAIL=0`),
|
||||
entries and keybindings. On the installed system, all 38 acceptance test cases
|
||||
in `installer/tests/vm/sys-acceptance.sh` pass cleanly (`PASS=38 FAIL=0`),
|
||||
verifying the unified AI-first CLI/GUI interface, deterministic `--legacy`
|
||||
mode, the package catalogue (search/inventory/information/update-check),
|
||||
fail-closed source requirements, audited `--broker`/`--legacy` gates,
|
||||
proactive system monitors, and offline fallback guidance.
|
||||
proactive system monitors, and offline fallback guidance. The matrix was
|
||||
re-run on 2026-09-26 against the refactored static `sys` (`70f0a72b…`,
|
||||
fetched to `/tmp/sys` on a disposable overlay of the pristine installed
|
||||
image, non-root user, no mutations): guest `PASS=38 FAIL=0`, driver
|
||||
`PASS=41 FAIL=0` (`serial-boot-20260926T014746Z-3089a820`).
|
||||
- **UKI** is deferred; the dracut UKI generator did not embed the kernel
|
||||
command line, so BLS is used (and verified).
|
||||
- **Rollback (`sys undo`) is NOT VM-verified.** It is implemented and
|
||||
|
|
|
|||
|
|
@ -711,6 +711,30 @@ detached boot verification with the live ISO removed.
|
|||
(`serial-boot-20260926T010605Z-e6193c3a`) also passed 11/11, with another
|
||||
`hello-world` install, refresh, removal and clean poweroff.
|
||||
|
||||
## 2026-09-26 — `sys` acceptance re-run against the refactored static binary
|
||||
|
||||
- Target: `sys-acceptance-refactor.qcow2`, a disposable overlay (absolute
|
||||
backing path, satisfying the harness disk-safety gate) of the pristine
|
||||
installed `fresh-install-1.qcow2` image. QEMU/OVMF booted the installed
|
||||
system detached; no physical disk was attached or modified.
|
||||
- Purpose: prove the quality-pass refactor (boxed `ExecError`, Clippy fixes,
|
||||
`service/` and `gui_bridge/` module splits) changed no behavior. The guest
|
||||
fetched the new static-pie `sys` (`SHA-256
|
||||
70f0a72b9ca4534250c2ee27417efffc0681da88ba4d2633da932813b0c0e044`,
|
||||
built from the post-split tree) to `/tmp/sys` and ran the current
|
||||
`installer/tests/vm/sys-acceptance.sh` with `SYS_BIN=/tmp/sys` as the
|
||||
non-root `phoebus` user with no mutations — so the matrix exercised the new
|
||||
binary, not the image's provisioned one.
|
||||
- Result `serial-boot-20260926T014746Z-3089a820`: guest
|
||||
`===SYS-ACC-END=== SUMMARY PASS=38 FAIL=0` (the full 38-case matrix:
|
||||
version/history/undo, failure cases, offline/model-free behavior, source
|
||||
selection, AI-first read-only workflow, catalogue including the
|
||||
`rdeps-legacy` regression, and non-root privilege refusals), driver
|
||||
`PASS=41 FAIL=0` (38 cases + login + `systemd is-system-running` +
|
||||
disposable-disk), exit 0.
|
||||
- Not covered by this run: the mutate group (`SYS_ACCEPTANCE_MUTATE=1`),
|
||||
recovery boot, strict Snap confinement, and a revision-changing Snap update.
|
||||
|
||||
## Known remaining work
|
||||
|
||||
- The graphical session was verified with the **headless** wlroots backend
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue